Skip to content

Draft: Update group two factor requirement in service

Jessie Young requested to merge jy-callback-to-service into master

What does this MR do and why?

  • Was previously in a callback, changed from an after_save to an after_commit here: !95424 (merged)
  • Was originally added as a callback due to MR feedback: "It would be better to run this in a callback, so it's in the same transaction as the save" (gitlab-foss!8763 (comment 22436612))
  • Given that this is now in an after_commit, it is not part of the same transaction anyway. Plus, it happens async so the single transaction part is not relevant.
  • This is a refactor not a behavior change. The hope is that moving code out of callbacks and into service objects makes it easier to read and understand.
  • #371552 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jessie Young

Merge request reports

Loading