Skip to content

Remove :seed_helper from Git::Commit spec

James Fargher requested to merge remove_seed_helper_from_git_commit into master

What does this MR do and why?

&8396

SeedHelper uses git to directly manipulate repositories within gitaly. Soon we will be enabling praefect by default and when this happens we cannot modify repositories without praefects knowledge.

This is a best effort translation from seed helper to rpsec factories. Most if not all of these specs already exist on the gitaly side. Since the factory repository is slightly different it's not always possible to exactly replicate the tests here.

There will be a followup to remove SeedHelper itself. This is more complex than it might immediately appear as the seed repositories have various associated scripts.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by James Fargher

Merge request reports