Skip to content

Move pages/help.scss styles to components/shortcuts_help

Scott de Jonge requested to merge 239834-help-page-specific-bundle into master

What does this MR do and why?

To continue breaking down page specific styles into individual page bundles #239834 (closed)

Discovered that help.scss contains styles for both help pages and shortcuts_help.vue.

  • Move pages/help.scss styles to components/shortcuts_help.scss
  • Remove .documention class styles, replace with utility classes
  • Remove .card.links-card class styles, replace with utility class

Screenshots or screen recordings

Description Before After
Help (light) help-light-before help-light-after
Help (dark) help-dark-before help-dark-after
Instance Configuration (light) instance-configuration-light-before instance-configuration-light-after
Instance Configuration (dark) instance-configuration-dark-before instance-configuration-dark-after
Shortcuts Help (light) shortcuts-help-light-before shortcuts-help-light-after
Shortcuts Help (dark) shortcuts-help-dark-before shortcuts-help-dark-after

How to set up and validate locally

  1. View /help and ensure links are blue-600 for both light and dark mode
  2. View /help/instance_configuration and ensure font-size and spacing
  • Note: removed 7px padding on single page to be consistent with other Help pages
  1. Press shift + ? to open Shortcuts Help modal and ensure layout and styles are maintained

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #239834 (closed)

Edited by Scott de Jonge

Merge request reports

Loading