Attach indent/outdent keys to toolbar buttons for cross platform support
What does this MR do and why?
Shifting blank line right should add spaces (!94718 - merged) added the ability to indent/outdent lines using shortcut keys. Originally implemented as toolbar buttons, before merging it was converted to capturing the keys directly (due to the toolbar being too wide).
Unfortunately that lost us the cross platform capability. Toolbar shortcuts automatically switch between Ctrl
and Cmd
based on the platform.
This MR re-implements the feature using toolbar buttons to regain cross platform ability. Now we just hide the buttons (which I should have done originally
Verified on Mac Safari/Chrome/Firefox, Windows Edge/Chrome/Firefox, and Ubuntu Firefox
How to set up and validate locally
- Use the Review App
- Show an edit box, such as editing description or comment.
- Verify the indent/outdent icons are not shown, which would look like this if not hidden:
- On a Mac,
cmd-]
andcmd-[
should indent/outdent selected text - On Windows,
ctlr-]
andctrl-[
should do the same
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #373902 (closed)