Skip to content

Clean up policy editor tests

Alexander Turinske requested to merge 359885-code-clean-up into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Clean up code

  • move the ee/spec/frontend/security_orchestration/components/policy_editor/scan_result_policy/lib/policy_rule_builder_spec.js test into the right directory, which is ee/spec/frontend/security_orchestration/components/policy_editor/scan_result_policy/policy_rule_builder_spec.js to match it's corresponding file, ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_result_policy/policy_rule_builder.vue
  • update code quality
  • remove unnecessary createComponents
  • unnest tests

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

N/A

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Turn on the :scan_execution_rule_mode feature flag
  3. Navigate to a project => Security & Compliance => Policies => New policy => Scan Execution Policy
  4. Type in a series of branches and ensure the label updates
  5. Navigate to a group => Security & Compliance => Policies => New policy => Scan Result Policy
  6. Select a branch and verify the branches label updates

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #359885 (closed)

Edited by Alexander Turinske

Merge request reports