Skip to content

Use sh instead of bash for scripts/slack

Lin Jen-Shin requested to merge use-sh-instead-of-bash into master

What does this MR do and why?

This was originally implemented in !97249 (merged) targeting ruby3-sync branch, which uses curlimages/curl image which doesn't have bash installed: https://gitlab.com/gitlab-org/gitlab/-/jobs/2991619602

It's proven working after switching to /bin/sh: https://gitlab.com/gitlab-org/gitlab/-/jobs/3046126754

In the default branch, we're using alpine which shouldn't have bash installed either, but we're installing it in the job: https://gitlab.com/gitlab-org/gitlab/-/blob/bee7cc717ec820b47a8e619e2298e97d17723288/.gitlab/ci/notify.gitlab-ci.yml#L9

I think this should work with /bin/sh, and maybe we don't need to install bash anymore. Actually, it doesn't seem like we need git either? Maybe we can just switch alpine to curlimages/curl and don't install any other packages. Happy to do that or we can just go with this first.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports