Skip to content

Use Pajamas button component for form submit

Jeremy Elder requested to merge 374782-use-pajamas-button-component-for-form-submit-in-app-views-admin-application_settings into master

What does this MR do and why?

Use pajamas_button: true instead of repeating CSS.

How to set up and validate locally

View the submit button for each updated instance. Replace the front of the URL with your local GDK instance:

  • /admin/application_settings/network under Issue Rate Limits
  • /admin/application_settings/network under Performance optimization
  • /admin/application_settings/network#js-note-limits-settings under Notes rate limit
  • /admin/application_settings/network#js-protected-paths-settings under Protected paths
  • /admin/application_settings/preferences under What's new
    • /gitlab-org/gitlab-test/-/settings/repository under Repository cleanup
  • /gitlab-org/gitlab-test/-/settings/repository under Default branch
  • /-/profile/password/edit
  • /-/profile/keys
  • Create a user using admin.
    • After saving, "Edit" the user and enter a password. Save.
    • Sign in as user using username and the password you created.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #374782 (closed), #374787 (closed), #374849 (closed), #374840 (closed), #374817 (closed), #374822 (closed), #374810 (closed), #374773 (closed), #374815 (closed), #374826 (closed)

Edited by Jeremy Elder

Merge request reports