Skip to content

Display shared runner details to group owners (1)

Miguel Rincon requested to merge 337838-show-runner-details-to-more-users into master

What does this MR do and why?

This change allows group owners to view the runner details page, previously they were met with a 404 result.

This change is part of a change that allows group owners more visibility of all runners, changes become relevant at !97108 (merged) where the runners get listed and the links must work.

MR
Display shared runner details to group owners (1) (!99084 - merged) ☝ you are here!
Show all runners for group (2) (!97108 - merged)
Add feature tests and documentation to "show on... (!99087 - merged)

Screenshots or screen recordings

NA

How to set up and validate locally

This is not meant to be a user facing change, but you may test that a group owner can visit an instance runner page:

  1. Logged in as as root/admin
  2. Visit Admin -> Runners
  3. Find the numeric id of an instance runner you have registered (e.g. 1)

You may impersonate another user for the next steps:

  1. Logged in as a group owner (not as root)
  2. Visit your group runners at Group -> CI/CD -> Runners e.g. http://gdk.test:3000/groups/top-group/-/runners
  3. Add the numeric id, e.g. /1 to the URL, http://gdk.test:3000/groups/top-group/-/runners/1

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #337838 (closed)

Edited by Miguel Rincon

Merge request reports