Skip to content

Add exception to run create e2e against gitaly changes

John McDonnell requested to merge jmd-selective-create-stage-e2e-against-gtialy-group into master

What does this MR do and why?

Recently we encountered an issue where updating the version of Gitaly did not detect a failure on the merge to master when updating the GITALY_SERVER_VERSION file. The job in question https://gitlab.com/gitlab-org/gitlab/-/jobs/3071155122#L115 on the merge only ran the tests in 12_systems due to the set of tags on the MR.

But then subsequently led to failures in master when the tests in the create stage were actually ran in the next master build.
#375198 (closed)
#375199 (closed)

Running just the 12_systems is really not enough to have confidence that Gitaly updates will work as expected. Given the relationship between Gitaly and Create we would always want to run the entire 3_create suite as well, as that is where we keep the majority of tests that interact with repositories and subsequently Gitaly.

This may be a common problem for multiple groups with the current implementation, so this change introduces some configuration to allow for mapping extra stages to a group, allowing to run both the E2E tests associated to the stage, but also a secondary (or more) stages.
It also introduces the first such configuration by mapping groupgitaly -> devopscreate

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by John McDonnell

Merge request reports