Resolve "Extract EE specific files/lines for app/views/admin/application_settings"
requested to merge 6098-extract-ee-specific-files-lines-for-app-views-admin-application_settings into master
What does this MR do?
This MR moves code from the following files to /ee
:
-
app/views/admin/application_settings/_account_and_limit.html.haml
-
app/views/admin/application_settings/_ci_cd.html.haml
-
app/views/admin/application_settings/_email.html.haml
-
app/views/admin/application_settings/_help_page.html.haml
-
app/views/admin/application_settings/_repository_mirrors_form.html.haml
-
app/views/admin/application_settings/_visibility_and_access.html.haml
Moreover, strings have been externalized in the partials above.
CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25955
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ee/issues/6098
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer
Closes #6098 (closed)
Edited by Martin Wortschack