Skip to content

Reduce Pages internal API cache duration

Kassio Borges requested to merge kassio/reduce-pages-internal-api-cache-duration into master

What does this MR do and why?

The GitLab Pages internal API cache, introduced in #363867 (closed), returns in the cached payload an URL that contains an expiration date of 24h.

To avoid serving an expired URL, with the cached data, we should reduce the cache expiration data to be lower than the 24h. To avoid any risks, it was proposed to reduce it initially to 12h and adjust when we have more data about the cache behavior.

Related to: #376105 (closed)

FAQ

  • Does it make sense to guard these changes under a FF?
    • The main feature, the cache itself, is behind a FF (cache_pages_domain_api, introduced in !88956 (merged))

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kassio Borges

Merge request reports