Adapt to new token architecture
After testing the GitLab Runner Operator v1.14.0 against the next token architecture, the follow observations were made:
- Registration Token is mandatory and the operator won't create the Runner Manager when not provided. It fails with the error:
2023-04-26T14:51:24.558Z ERROR controller-runtime.manager.controller.runner Reconciler error {"reconciler group": "apps.gitlab.com", "reconciler kind": "Runner", "name": "gitlab-runner", "namespace": "default", "error": "runner-registration-token key not found in gitlab-runner-secret secret"}
- When the registration is provided, it still fails with the error below. I believe it might be linked to the command used for the registration having some unwanted params
FATAL: Runner configuration other than name and executor configuration is reserved and cannot be specified when registering with a runner token. This configuration is specified on the GitLab server. Please try again without specifying those arguments.
With this MR we keep the registration-token
fields and disabled the use of the following arguments when using an authentication token:
Tests Results
Auth token
Log when using legacy token
close #148 (closed)
Edited by Romuald Atchadé