Skip to content

Add postgresql_config resource

Ian Baum requested to merge use-postgresql_config-resource into master

  • Intended to allow us to limit the notifications sent out to one if any of any of the config files change.

  • Removes postgresql.conf specs from gitlab-rails spec. These don't work with postgresql_config, and this isn't the right place for those tests anyway. They should be tested in postgresql specific tests already

Related to #4692 (closed)

Issue being fixed is described in !3631 (comment 223343507)

I think the current state we're running into an issue with the way notifications are happening.

The postgresql::enable recipe sets up four configuration files, and notifies immediately to start or reload postgresql if any of them change.

On upgrade, the first file change, which results in the first file starting postgresql immediately. This means if there are any subsequent changes that only take effect on a full restart, then they won't be picked up since we don't automatically restart postgresql.

I think grouping all of these into a custom resource, and notifying if the resource change is the way to go.

Edited by GitLab Release Tools Bot

Merge request reports