Skip to content

Resolve "Enable Container Registry by default"

Ian Baum requested to merge 4690-enable-container-registry-by-default into master

If Let's Encrypt integration is being used, and registry is not configured on a different domain, then we should enable the registry by default. We should listen on port 5050 on the same domain as exernal_url using the Let's Encrypt certificates.

Test plan: Fresh installs

  • With http does not enable the registry
  • With letsencrypt['enable'] = false does not enable the registry
  • With a relative url does not enable the registry
  • With https and no registry_external_url enables the registry using the same domain as external_url and port 5050
  • With https registry_external_url' does not use the same domain as external_url, only uses registry_external_url` on standard ports
  • Changing registry_nginx['listen_port'] changes the port users connect to the registry on

Upgrades

  • From previous version using https and no registry_external_url enables the registry on external_url using port 5050
  • From previous version using http and no registry_external_url does not enable the registry
  • From previous version using registry_external_url does not alter the registry

Closes #4690 (closed)

Edited by GitLab Release Tools Bot

Merge request reports

Loading