Skip to content

Fix misformatted error

DJ Mountney requested to merge fix-pg-upgrade-error-message into master

Ensure the proper error is thrown

Without this we get the following when an error appears:

Traceback (most recent call last):
    10: from /opt/gitlab/embedded/bin/omnibus-ctl:23:in `<main>'
     9: from /opt/gitlab/embedded/bin/omnibus-ctl:23:in `load'
     8: from /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/omnibus-ctl-0.6.0/bin/omnibus-ctl:31:in `<top (required)>'
     7: from /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/omnibus-ctl-0.6.0/lib/omnibus-ctl.rb:746:in `run'
     6: from /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/omnibus-ctl-0.6.0/lib/omnibus-ctl.rb:204:in `block in add_command_under_category'
     5: from /opt/gitlab/embedded/service/omnibus-ctl/pg-upgrade.rb:187:in `block in load_file'
     4: from /opt/gitlab/embedded/service/omnibus-ctl/pg-upgrade.rb:329:in `geo_secondary_upgrade'
     3: from /opt/gitlab/embedded/service/omnibus-ctl/lib/gitlab_ctl/pg_upgrade.rb:130:in `run_pg_upgrade'
     2: from /opt/gitlab/embedded/service/omnibus-ctl/lib/gitlab_ctl/pg_upgrade.rb:130:in `raise'
     1: from /opt/gitlab/embedded/service/omnibus-ctl/lib/gitlab_ctl/pg_upgrade.rb:130:in `exception'
/opt/gitlab/embedded/service/omnibus-ctl/lib/gitlab_ctl.rb:27:in `initialize': wrong number of arguments (given 1, expected 3) (ArgumentError)

As seen in #5242 (closed)

Merge request reports