Skip to content

Inline Gitaly gRPC recording rule

Ben Kochie requested to merge bjk/no_record_gitaly_grpc into master

What does this MR do?

Gitaly produceds about 2500 grpc_server_handled_total metrics by default, this results in the same amount of recorded metrics. By inlining the rate(), we can reduce the number of metrics stored by Prometheus in the default stand-alone setup by 15%.

This saves about 400MiB of the default 2500MiB of Prometheus metrics.

Related issues

#4166 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Ian Baum

Merge request reports