Skip to content

Exclude windows .ruby files from gems

DJ Mountney requested to merge exclude-win-ruby-files into master

What does this MR do?

Removes unnesessary .ruby windows files from our gems

This currently only impacts the grpc gem, but seems good to apply to all:

root@6095b0251da5:/opt/gitlab/embedded# find /opt/gitlab/embedded/ -name '*.ruby' -type f -print
/opt/gitlab/embedded/service/gitlab-rails/app/views/issues/_issues_calendar.ics.ruby
/opt/gitlab/embedded/lib/ruby/gems/2.7.0/gems/grpc-1.30.2-x86_64-linux/grpc_c.64.ruby
/opt/gitlab/embedded/lib/ruby/gems/2.7.0/gems/grpc-1.30.2-x86_64-linux/grpc_c.32.ruby

Related issues

Part of the investigation of #5874 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports