Draft: Update nginx header settings
What does this MR do?
- Refator nginx proxy_set_header to allow for un-setting headers with empty string.
- Add a un-set for
Client-Ip
to avoid rails processing of this invalid header.
Related issues
Related to production incident: gitlab-com/gl-infra/production#3428 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Edited by Ben Kochie