Skip to content

Adds an additional include_ee? check to prep for additional packages

DJ Mountney requested to merge package-include-ee into master

What does this MR do?

The idea is to have packages that include the ee source and license, but aren't specifically the gitlab-ee package. (How those would work, is that they would be added as additional checks in inlude_ee?)

A cleaner way might be some metadata info that has keys indexed by package name that indicates whether a package is supposed to include ee or not. But I'm not sure its worth the effort at this point.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by DJ Mountney

Merge request reports

Loading