Skip to content

Simplify the triggerring of 'gitlab-docs' Review App pipelines

Rémy Coutable requested to merge simplify-docs-review-app-trigger into master

What does this MR do?

This makes the project compatible with the new version of the script made at gitlab!53361 (merged).

Because the docs Review App deployment was made simpler in gitlab-docs with gitlab-docs!1493 (merged), this requires a few changes to work with gitlab!53361 (merged).

Example Review App (fetching the trigger-build script from the simplify-docs-review-app-trigger branch): http://master-omnibus-simplify-docs-review-app-trigger.178.62.207.141.nip.io/omnibus/README.html

Related issues

Related to gitlab-docs!1493 (merged), gitlab!53361 (merged), and gitlab-runner!2809 (merged).

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Rémy Coutable

Merge request reports

Loading