Make S3 buckets configurable via environment variables
requested to merge vincent_stchu/omnibus-gitlab:make-s3-settings-configurable-via-env-vars into master
What does this MR do?
Currently the tasks that sync & download packages in S3 is hard-coded in rake scripts. In Jihu we need to upload packages to TencentCloud COS (an object storage service which is compatible with S3). In such case, the command aws s3 parameters like endpoint-url, region and bucket name should be easily configured through variables.
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-packagehas a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Edited by vincent stchu