Skip to content

Fix an error where reconfigure would swap the praefect election strategy

DJ Mountney requested to merge fix-logic-error-in-praefect-election into master

What does this MR do?

Switches from using include? to grep on the search for election strategy in the praefect config.

include? on a enumerable is looked for full matching content, not searching for a pattern. In real use the lines will have newlines and won't exactly match what we were looking for.

This was causing a behaviour, where if you don't explicitely set the election strategy, the first reconfigure would use per_repository but the following reconfigures would swap to sql

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by DJ Mountney

Merge request reports