Add docs about when to remove deprecation code

What does this MR do?

We have docs on when and how to add a deprecation notice, but not on when to remove it. I propose we keep it in there until the version where it is removed is out of maintenance window.