Skip to content

Do not use `gitlab-ctl upgrade-check` command in preinst but use inline check

Balasankar 'Balu' C requested to merge temp-fix-upgrade-message into master

What does this MR do?

Fall back to in-line upgrade check in preinst to ensure correct error message is shown to the user. The upgrade check library and gitlab-ctl command was added in !4381 (merged) for implementing an upgrade check for Docker. We are removing it from the package installation process because in this scenario, it runs with existing code and not incoming code and we can't introduce fixes easily. We can continue using it for Docker because in the case of Docker, it runs with incoming code.

Closes: #6213 (closed)

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Balasankar 'Balu' C

Merge request reports