Skip to content

Gracefully handle empty roles

Stan Hu requested to merge sh-gracefully-handle-empty-roles into master

What does this MR do?

If a gitlab-ctl reconfigure fails, the JSON might be left with empty roles. We should gracefully handle this case and not fail hard.

Related issues

https://about.gitlab.com/releases/2021/09/22/gitlab-14-3-released/#comment-5544935849

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Stan Hu

Merge request reports