Skip to content

Deprecate Pages daemon-* flags

feistel requested to merge feistel/omnibus-gitlab:deprecate/daemon-flags into master

What does this MR do?

We have now disabled chroot by default since %14.1, and recently removed support for disk-based configuration coming in %14.3. And we've also removed the chroot completely from Pages.

However, we still support daemonizing and in fact Omnibus still configures Pages to run as daemon https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/5b4022e03873d3b38b466b17b633812b175fc0fe/files/gitlab-cookbooks/gitlab-pages/templates/default/gitlab-pages-config.erb#L4.

We should deprecate the following flags:

daemon-uid
daemon-gid
daemon-inplace-chroot

And give way to gitlab-pages#133 (closed)

Related issues

Closes #6381 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Jason Plum

Merge request reports

Loading