Skip to content

Remove lexographic Danger race condition

Robert Marshall requested to merge remove-lexographic-race-condition-in-danger-jobs into master

What does this MR do?

Removes a lexographic race condition that causes collisions in Danger job messages such as seen in https://gitlab.com/gitlab-org/omnibus-gitlab/-/jobs/1648941121#L35.

$ danger --fail-on-errors=true
scripts/support/reviewers/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE
scripts/support/software/Dangerfile:9: warning: previous definition of MESSAGE was here
Results:

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports