Conditionally generate public_attributes.json
requested to merge 6446-patroni-not-generating-public_attributes-when-patroni_role-is-enabled into master
What does this MR do?
Conditionally generate public_attributes.json. When skip-auto-reconfigure
is set, the file was still being generated, but without the full calculation of attributes. On Patroni node upgrades, this would break gitlab-ctl patroni
commands until a full reconfigure
was run since the upgrade will run the postgresql-bin recipe without all of the attributes.
Related issues
Closes #6446 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Test plan
Current state
On a node with patroni enabled:
-
gitlab-ctl patroni members
should work - Run
touch /etc/gitlab/skip-auto-reconfigure
- Run
gitlab-ctl upgrade
(to simulate a package upgrade) - Running
gitlab-ctl patroni members
should fail - Run
gitlab-ctl reconfigure
-
gitlab-ctl patroni members
should work again
Expected state
On a node with patroni enabled:
-
gitlab-ctl patroni members
should work - Run
touch /etc/gitlab/skip-auto-reconfigure
- Run
gitlab-ctl upgrade
(to simulate a package upgrade) - Running
gitlab-ctl patroni members
should still work
Edited by DJ Mountney