Skip to content

Do not set REDISCLI_AUTH to empty string

Robert Marshall requested to merge do-not-set-REDISCLI_AUTH-to-empty-string into master

What does this MR do?

While testing !5929 (merged), I ran across this error:

AUTH failed: ERR AUTH <password> called without any password configured for the default user. Are you sure your configuration is correct?

This comes about because a single node Omnibus GitLab installation using UNIX sockets for redis will not use a password.

The /usr/bin/gitlab-redis-cli script, when invoked, will automatically set REDISCLI_AUTH. If this is an empty string, then the user receives the error message above.

Related issues

Related gitlab-com/gl-infra/production#6397 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports