Skip to content

Run generate-facts in cache update pipeline from gitlab-org/gitlab

Balasankar 'Balu' C requested to merge 6709-fix-generate-facts-gitlab-nightly-triggers into master

What does this MR do?

One of the scheduled pipelines in gitlab-org/gitlab triggers a pacakge-and-qa pipeline in omnibus-gitlab-mirror passing CACHE_UPDATE variable (due to gitlab!67822 (merged)). Because we were skipping generate-facts on presence of CACHE_UPDATE variable (the other place where we use this is our own schedules which doesn't do any qa triggers, and thus doesn't require generate-facts), this triggered pipeline will fail due to missing dependency jobs, like in https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/485340905.

This MR changes the skip so that generate-facts is skipped only in our schedules, and not the trigger from gitlab-org/gitlab.

Related issues

Closes #6709 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports