Skip to content

Properly escape S3 credentials in Workhorse config TOML

Stan Hu requested to merge sh-fix-workhorse-s3-toml into master

What does this MR do?

Having a literal backslash \ in a string that gets rendered into Workhorse's config.toml results in an invalid TOML file.

We solved this problem in gitlab-org/charts/gitlab!2639 (merged) by converting the string to JSON. While this works for Go, we also have to be careful about handling null values in Ruby.

Related issues

Closes #6908 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Stan Hu

Merge request reports