Skip to content

Revert "Merge branch 'sh-make-fips-ee' into 'master'"

Balasankar 'Balu' C requested to merge revert-e53520c1 into master

What does this MR do?

The presence of ee in the job makes Gitlab think that even a CE nightly is an EE one, and have FIPS builds and trigger a RAT pipeline in the CE nightly pipeline, as seen from https://dev.gitlab.org/gitlab/omnibus-gitlab/-/pipelines/245795. However, we still pass the EE QA image to the trigger, thus causing failures downtime. We might be able to solve the QA issue, but I don't think we currently have a need for CE FIPS builds at all. So, this is essentially a wastage of compute and space, and we can add this back if we find a need.

However, the edge case of someone manually enabling FIPS builds on all branch builds and then not forcing an EE pipeline still exists.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Balasankar 'Balu' C

Merge request reports

Loading