Bump Consul version to 1.12.5
What does this MR do?
Bump Consul version to 1.12.5 to support Go 1.18.
Notes
- TLS configuration has been enhanced to support per-endpoint settings. Hence, the global configuration been moved from top level of the configuration hash to
tls.default
(along withtls.http
andtls.grpc
) stanzas. While we can move this in the backend quite easily, because we didn't expose all the TLS settings viagitlab.rb
, there is a possibility of users setting this directly viaconsul['configuration']
and not using the dedicated settings ingitlab.rb
. So, I think we should be handling this for them. - Another deprecation/renaming is of
acl.tokens.master
andacl.tokens.agent_master
settings, which have been renamed toacl.tokens.initial_management
andacl.tokens.agent_recovery
.
Testing
Note: While testing multi-node systems, verify if functionality works when multiple Consul servers are on different versions
- TLS functionality
-
Fresh installations -
Upgrades
-
- Fresh single node installations
-
Service Discovery
-
- Single node installations upgrade
-
Shows warning to restart Consul -
Service Discovery still works
-
- Fresh installation - PG HA - Covered by gitlab-org/quality/quality-engineering/team-tasks#1489 (closed)
-
Patroni failover still works
-
- PG HA upgrades - Covered by gitlab-org/quality/quality-engineering/team-tasks#1489 (closed)
-
Patroni failover still works
-
- Fresh installation - Geo - Covered by gitlab-org/quality/quality-engineering/team-tasks#1493 (closed)
-
Promote DB works
-
- Geo upgrades - Covered by gitlab-org/quality/quality-engineering/team-tasks#1493 (closed)
-
Promote DB works
-
Related issues
Closes #7213 (closed)
Related to &8843 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall