Skip to content

Ensure Workhorse is built in FIPS mode

Stan Hu requested to merge sh-build-workhorse-fips into master

What does this MR do?

Previously Workhorse was not compiled properly for FIPS since the fips build tag was not defined, so LabKit's fips.Enabled() would erroneously return false. The FIPS_MODE=1 environment variable makes Workhorse activate the right build settings.

This came out an investigation of Maven package handling in gitlab#380559 (closed).

Related issues

gitlab#380559 (closed)

Testing

[stanhu@stanhu-fips1 bin]$ ./gitlab-workhorse
INFO[0000] Starting                                      build_time=20221216.094924 version=11-10-0cfa69752d8-74ffd66ae-ee-187173-g031da1d300c1
INFO[0000] FIPS mode is enabled. Using an external SSL library.
INFO[0000] Running upstream server                       address="localhost:8181" network=tcp

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Stan Hu

Merge request reports

Loading