Add support for go-crond flags
What does this MR do?
Add support for go-crond flags
Parse and pass flags (https://github.com/webdevops/go-crond#usage) from
crond['flags'] dictionary to the go-crond service.
For example, --verbose and --server.bind can be configured by setting:
'''
crond['flags'] = {
'verbose': true,
'server.bind': '0.0.0.0:7000'
}
'''
The include flag (configurable via crond['cron_d']) can not be
configured with the flags dictionary.
Changelog: added
Issue: https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6938
Related issues
Closes #6938 (closed)
Test Plan
-
Set
external_url
to an https URL -
Set
crond[flags] = { 'verbose': true }
-
Run
gitlab-ctl reconfigure
-
Confirm the verbose flag was passed to go-crond:
ps -aux | grep go-crond | head -n1 root 2302 0.0 0.0 718836 7220 ? Ssl 10:30 0:00 /opt/gitlab/embedded/bin/go-crond --verbose --include=/var/opt/gitlab/crond
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-package
jobs have a green pipeline running against latest commit. -
Ifconfig/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then theTrigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed todev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Clemens Beck