Skip to content

Stop sidekiq namespaced probe for gitlab-exporter

Sylvester Chin requested to merge sc1-stop-namespace-probe into master

What does this MR do?

This MR bumps the gitlab-exporter version from 13.5.0 to 14.0.0. This stops the exporter from probing Redis for namespaced Sidekiq keys. This is part of a series of releases in gitlab-com/gl-infra/scalability#2288 (closed).

In 16.4, we started polling both namespaces. In 16.6, we deprecate the use of namespace in Gitlab Rails and provided post-deployment migrations. Hence in 16.7, we are dropping the dual-polling support and removing metrics for namespaced keys in Sidekiq since a 16.6 -> 16.7 upgrade would see no metrics in the namespaced probes.

Related issues

gitlab-com/gl-infra/scalability#2288 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened. - gitlab-org/charts/gitlab!3479 (merged)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Sylvester Chin

Merge request reports