Skip to content

Create git_data_dirs even if gitlab_rails is disabled

What does this MR do?

Currently, gitlab_rails service needs to be enabled in order for gitaly service to function properly. Specifically, gitlab_rails creates git_data_dirs (e.g. /var/opt/gitlab/git-data/repositories) which is needed for Gitaly to start-up. If only the gitaly service is enabled, then Gitaly won't start due to config validation error (i.e. storage directories have to be present).

This MR makes the creation of these directories the responsibility of the gitaly cookbook. The gitlab cookbook still creates the directories as backward-compatibility measure, as I'm not sure if these directories are needed outside of Gitaly.

Related issues

This is needed as part of https://gitlab.com/gitlab-com/gl-infra/production-engineering/-/issues/24530.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jason Plum

Merge request reports

Loading