Omnibus: Updates docs-lint image for new SVG use
What does this MR do?
In gitlab!147384 (merged), @lauraXD discovered that a badge image available in https://gitlab-org.gitlab.io/gitlab-svgs/ was causing a pipeline error when using it in the UI:
ArgumentError: partner-verified is not a known icon in @gitlab-org/gitlab-svg
926lib/helpers/icons_helper.rb:22:in `icon':
partner-verified is not a known icon in @gitlab-org/gitlab-svg (ArgumentError)
Our internal Technical Writing documentation gives instructions on what to do. I've created gitlab-docs#1777 (closed) to update the linting images.
This MR is one of a set to make the new images available in our major repos, to unblock Laura.
Related items
- Related to Frontend: Add badge for components (gitlab!147384 - merged) where the need was discovered
- Related to Update the html-lint Docker image (gitlab-docs#1777 - closed) where I'm tracking the overall work
- Related to Update CI YAML with link to new image (gitlab-docs!4676 - merged) where I first updated the
gitlab-docs
repo to use the new image
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-package
jobs have a green pipeline running against latest commit. -
If config/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.