Skip to content

Paginate through Web Merge Request discussions

Nailia Iskhakova (OOO) requested to merge 524-mr-discussion-pagination into main

The paginated_mr_discussions has been enabled by default in 15.3 (gitlab-org/gitlab#342612 (comment 1059554169)). The MR updates web_project_merge_request to paginate over discussions similar to !433 (merged)

Test against 10k env 
     █ Web - Project Merge Request Page

     data_received....................................................................: 118 MB  1.9 MB/s
     data_sent........................................................................: 266 kB  4.3 kB/s
     group_duration...................................................................: avg=7536.89ms min=1965.78ms med=7974.01ms max=8655.00ms p(90)=8143.25ms p(95)=8234.12ms
     http_req_blocked.................................................................: avg=0.18ms    min=0.00ms    med=0.01ms    max=3.65ms    p(90)=0.75ms    p(95)=0.79ms
     http_req_connecting..............................................................: avg=0.15ms    min=0.00ms    med=0.00ms    max=1.11ms    p(90)=0.63ms    p(95)=0.67ms
     http_req_duration................................................................: avg=191.23ms  min=63.11ms   med=167.64ms  max=734.27ms  p(90)=442.60ms  p(95)=467.75ms
       { expected_response:true }.....................................................: avg=191.23ms  min=63.11ms   med=167.64ms  max=734.27ms  p(90)=442.60ms  p(95)=467.75ms
     http_req_failed..................................................................: 0.00%   ✓ 0         ✗ 1225
     http_req_receiving...............................................................: avg=1.53ms    min=0.05ms    med=1.37ms    max=34.73ms   p(90)=2.71ms    p(95)=3.14ms
     http_req_sending.................................................................: avg=0.05ms    min=0.01ms    med=0.04ms    max=0.22ms    p(90)=0.09ms    p(95)=0.10ms
     http_req_tls_handshaking.........................................................: avg=0.00ms    min=0.00ms    med=0.00ms    max=0.00ms    p(90)=0.00ms    p(95)=0.00ms
     http_req_waiting.................................................................: avg=189.65ms  min=63.02ms   med=166.06ms  max=732.21ms  p(90)=440.84ms  p(95)=466.17ms
     ✓ { controller:Projects::MergeRequests::ContentController#cached_widget.json }...: avg=115.07ms  min=99.70ms   med=113.27ms  max=177.84ms  p(90)=128.56ms  p(95)=134.96ms
     ✓ { controller:Projects::MergeRequests::ContentController#widget.json }..........: avg=108.13ms  min=95.40ms   med=104.66ms  max=152.46ms  p(90)=125.07ms  p(95)=135.80ms
     ✓ { controller:Projects::MergeRequestsController#discussions.json }..............: avg=188.40ms  min=143.46ms  med=178.55ms  max=732.21ms  p(90)=225.62ms  p(95)=238.30ms
     ✓ { controller:Projects::MergeRequestsController#show.json }.....................: avg=72.57ms   min=63.02ms   med=68.43ms   max=139.16ms  p(90)=84.09ms   p(95)=100.66ms
     ✓ { controller:Projects::MergeRequestsController#show }..........................: avg=464.36ms  min=415.31ms  med=460.83ms  max=622.25ms  p(90)=502.21ms  p(95)=511.74ms
   ✓ http_reqs........................................................................: 1225    19.648379/s
     ✓ { controller:Projects::MergeRequests::ContentController#cached_widget.json }...: 153     2.454042/s
     ✓ { controller:Projects::MergeRequests::ContentController#widget.json }..........: 153     2.454042/s
     ✓ { controller:Projects::MergeRequestsController#discussions.json }..............: 612     9.81617/s
     ✓ { controller:Projects::MergeRequestsController#show.json }.....................: 153     2.454042/s
     ✓ { controller:Projects::MergeRequestsController#show }..........................: 153     2.454042/s
     iteration_duration...............................................................: avg=7492.68ms min=722.49ms  med=7973.78ms max=8655.04ms p(90)=8138.92ms p(95)=8233.35ms
     iterations.......................................................................: 153     2.454042/s
   ✓ successful_requests..............................................................: 100.00% ✓ 1224      ✗ 0
     vus..............................................................................: 4       min=1       max=20
     vus_max..........................................................................: 20      min=20      max=20


█ Results summary

* Environment:                10k
* Environment Version:        15.4.0-pre `f70efa51314`
* Option:                     60s_200rps
* Date:                       2022-09-16
* Run Time:                   1m 5.58s (Start: 13:46:33 UTC, End: 13:47:38 UTC)
* GPT Version:                v2.11.0

❯ Overall Results Score: 98.25%

NAME                      | RPS  | RPS RESULT         | TTFB AVG | TTFB P90           | REQ STATUS     | RESULT
--------------------------|------|--------------------|----------|--------------------|----------------|-----------------
web_project_merge_request | 20/s | 19.65/s (>16.00/s) | 189.65ms | 440.84ms (<1800ms) | 100.00% (>99%) | Passed¹

Closes #524 (closed)

Merge request reports