Skip to content

Resolve "Running RSpec locally produces a lot of warnings"

Ash McKenzie requested to merge 925-running-rspec-locally-produces-a-lot-of-warnings into master

What does this MR do and why?

This MR has a few quality of life fixes to reduce the noise produced when running bundle exec rspec:

$ bundle exec rspec --format progress

Randomized with seed 44209
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Top 10 slowest examples (1.66 seconds, 72.1% of total time):
  DevopsLabels DevopsLabels::Context#group_for_user returns nil when team refers to stage
    0.4407 seconds ./spec/lib/devops_labels_spec.rb:808
  DevopsLabels DevopsLabels::Context#all_category_labels_for_stage returns the stage category labels when given a stage name
    0.27687 seconds ./spec/lib/devops_labels_spec.rb:323
  DevopsLabels DevopsLabels::Context#group_for_user returns the group name of the matching group for user
    0.27019 seconds ./spec/lib/devops_labels_spec.rb:800
  DevopsLabels DevopsLabels::Context#current_section_label returns the section label if the resource has a section label and a nested "sub-section" label
    0.25384 seconds ./spec/lib/devops_labels_spec.rb:132
  Triage::PercentageRollout with processors having percentage roll out processes the given percentages of events
    0.12972 seconds ./spec/triage/percentage_rollout_spec.rb:74
  TeeStream.exec captures command status, output and error streams
    0.12004 seconds ./spec/lib/tee_stream_spec.rb:20
  TeeStream.exec writes command stdout and stderr to provided streams
    0.11696 seconds ./spec/lib/tee_stream_spec.rb:31
  Triage::ReactiveReviewer behaves like rate limited does not post a comment if number of commands sent exceeds the allowed limit within the period
    0.02579 seconds ./spec/support/rate_limit_shared_examples.rb:2
  Triage::ReactiveLabeler#process behaves like rate limited does not post a comment if number of commands sent exceeds the allowed limit within the period
    0.0237 seconds ./spec/support/rate_limit_shared_examples.rb:2
  Triage::Event#wider_gitlab_com_community_author? behaves like wider community author methods when author is a member of the gitlab-com group and a community core team member returns true
    0.00628 seconds ./spec/triage/event_spec.rb:453

Top 10 slowest example groups:
  TeeStream
    0.07932 seconds average (0.23797 seconds / 3 examples) ./spec/lib/tee_stream_spec.rb:6
  Triage::PercentageRollout
    0.04359 seconds average (0.13077 seconds / 3 examples) ./spec/triage/percentage_rollout_spec.rb:8
  DevopsLabels
    0.0092 seconds average (1.32 seconds / 143 examples) ./spec/lib/devops_labels_spec.rb:6
  Triage::Rack::Authenticator
    0.00202 seconds average (0.00606 seconds / 3 examples) ./spec/rack/authenticator_spec.rb:7
  Triage::ReactiveReviewer
    0.0019 seconds average (0.03418 seconds / 18 examples) ./spec/processor/reactive_reviewer_spec.rb:7
  Triage::ReactiveLabeler
    0.00162 seconds average (0.03235 seconds / 20 examples) ./spec/processor/reactive_labeler_spec.rb:7
  Triage::RemindMergedMrDeviatingFromGuideline
    0.00152 seconds average (0.02576 seconds / 17 examples) ./spec/processor/remind_merged_mr_deviating_from_guidelines_spec.rb:8
  AddLegalDisclaimerToEpic
    0.00151 seconds average (0.00603 seconds / 4 examples) ./spec/lib/add_legal_disclaimer_to_epic_spec.rb:6
  Triage
    0.00148 seconds average (0.02072 seconds / 14 examples) ./spec/triage_spec.rb:5
  Triage::PajamasMissingWorkflowLabelOrWeight
    0.00146 seconds average (0.01023 seconds / 7 examples) ./spec/processor/pajamas_missing_workflow_label_or_weight_spec.rb:9

Finished in 2.31 seconds (files took 1.18 seconds to load)
1564 examples, 0 failures

Randomized with seed 44209

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review

Closes #925 (closed)

Merge request reports