Skip to content

Polish the message for contributor feedback

Amy Qualls requested to merge aqualls-improve-contrib-feedback-msg into master

What does this MR do and why?

Improves the contributor experience feedback request in triage/processor/code_review_experience_feedback.rb and updates the test in spec/processor/code_review_experience_feedback_spec.rb to match it. I saw the comment in a merge request when I was researching a question earlier today, and thought we could improve it in a few ways:

  • Smooth out the language, but keep the politeness
  • Fix a typo
  • Put the steps in an ordered list
  • Invoke and link to our our values

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review

Merge request reports