Skip to content

Fix SlackNotifier by passing an actual Hash to the #ping method

Rémy Coutable requested to merge fix-slack-notifier-class into master

What does this MR do and why?

The new PipelineFailureManagement processor is working as expected (it created https://gitlab.com/gitlab-org/quality/engineering-productivity/triage-ops-playground/-/issues/13), but the Slack notification was sent as raw text instead of as blocks, see https://gitlab.slack.com/archives/C045P740HJB/p1680188705341199.

This MR fixes it.

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-with-a-dry-run on how to perform dry-runs for new policies.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.

Action items

Edited by Rémy Coutable

Merge request reports

Loading