Skip to content

Fix SlackNotifier by passing the hash directly anot via 'blocks:'

Rémy Coutable requested to merge fix-slack-notifier-class-2 into master

What does this MR do and why?

I tried to fix the notifier class with !2129 (merged), but I realized that blocks: should only contain the actual blocks. 🤦🏼

So I extracted common keyword arguments to the class itself, and now pass the Slack payload hash as **hash instead as of blocks: hash.

I tried locally in rack-console and managed to send a test message this way, see https://gitlab.slack.com/archives/C045P740HJB/p1680286180949059.

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-with-a-dry-run on how to perform dry-runs for new policies.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.

Action items

Edited by Rémy Coutable

Merge request reports

Loading