Skip to content

Allow SkipEscalationUponHumanUpdate react to issue.note event as well

Jennifer Li requested to merge jennli-accept-issue-note-event into master

What does this MR do and why?

Enhance the SkipEscalationUponHumanUpdate processor to allow it react to issue.note events.

Purpose:

Team members triaging master broken incidents aren't always updating the incident status; instead, they respond by leaving a comment. Such commenting action did not trigger the escalation::skipped label because it is a issue.note event, not a incident.update event. This MR ensure that issue.note events also allow us to skip escalation.

Re: gitlab-org/quality/engineering-productivity/team#547

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-policies-with-a-dry-run on how to perform dry-runs for new policies.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.

Action items

Edited by Jennifer Li

Merge request reports

Loading