RuboCop update extravaganza
As part of gitlab-com/gl-infra/delivery#1357 (closed), I'm planning to add a custom cop to avoid literal 'master'
strings. I figured it made sense to make sure our RuboCop was up-to-date first.
83636760 - Update rubocop to 0.85.0
Disables new Lint/MixedRegexpCaptureTypes
cop and fixes
Style/RedundantRegexpEscape
violations.
f3097d7a - Update rubocop to 0.87.0
Fixes Style/RedundantAssignment
violation and disables
Style/AccessorGrouping
.
00e0239f - Update rubocop to 0.88.0
Fixes Layout/FirstArgumentIndentation
violations.
e314bbac - Enable BlockLength and MethodLength cops
At some point these cops got configurations to treat certain multi-line literals as one line. So spreading a Hash definition out over 15 lines only counts as one line, for example.
That makes these cops more reasonable to enable.
8f38b23f - Update rubocop to 0.93.1
Disables Lint/MissingSuper
Fixes:
Style/ExplicitBlockArgument
Style/StringConcatenation
Layout/BeginEndAlignment
Layout/RescueEnsureAlignment
Style/KeywordParametersOrder
f58a5de6 - Update rubocop to 1.0.0; rubocop-rspec to 2.0.1
f40d0e92 - Update rubocop to 1.6.1
Fixes Lint/EmptyBlock
; disables others.
554b2108 - Add rubocop-performance
Fixes:
Performance/Count
Performance/DeletePrefix
Performance/MethodObjectAsBlock
Performance/RegexpMatch
Performance/StringReplacement
Edited by Robert Speicher