Skip to content

Cleanup unused QA generation code

John Skarbek requested to merge jts/clean-up-a-bit-again into master
  • QA was previously being sent a lot of information that it no longer needs
    • Back in the day, we used to run this QA task code for EVERY deploy
    • We now only run this when we successfully deploy to gstg-cny
    • Because of this, the majority of the QA builder can be removed
  • This removes the rake task from requiring the environment and status
    • We now hardcode the underlying methods to a specific target environment, in this case gstg-cny
    • We completely remove the status requirement
  • Changes the underlying rake task to no longer rely on a helper function now that some of this unused functionality is no longer required
    • This removes that helper entirely
  • I suspect we used to run the rake task release:qa, but now, this task is no longer called anywhere, so let's remove it
  • Rename the qa_commit_range to commit_range because this is not specific to QA, but instead specific to gathering a range of commits that come from the deployment tracker service
    • Update all tests and uses of the commit_range where version is a required parameter, all others are optional
  • updates our rake task to now only require the bits it needs, the version

Closes: gitlab-com/gl-infra/delivery#2328 (closed)

Merge request reports

Loading