Refactor class to generate security issues table
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR refactors the Security::IssuesTable
class.
Move code to generate the table to a separate class called Security::IssueTable::Builder
(open to naming suggestions) that returns
the table as a string, which the existing Security::IssuesTable
class then posts to the issue.
This makes it easier to test, and reduces the responsibilities of each class.
I've not refactored the specs in the same MR since the MR was becoming too large. I'll open a follow-up MR to refactor the specs.
In another follow-up MR I plan to move the Security::IssuesTable
class into the IssueTable
module and rename the class to Service
or Coordinator
.
Author Check-list
-
Has documentation been updated?
Edited by Reuben Pereira