Skip to content

Add CNG to early merge projects

Steve Abrams requested to merge cng-early-merge into master

What does this MR do and why?

This MR adds CNGImage to the list of projects that are allowed to early merge in the security release. This means that the merge requests targeting the default branch for security issues for CNG will automatically be merged when release managers run the early merge chatops command.

I also refactored a few places that had duplicate IDs while I was in the code.

Here is why I believe we are able to enable this feature for CNG:

According to this discussion regarding omnibus-gitlab, merged result pipelines are needed to allow early merge: !1955 (comment 1041152773). I believe this along with the general tech debt of CNG not commonly having security fixes is the only reason we have not enabled the feature for CNG. We recently went through all of the managed versioning projects and looked at the settings when preparing for the updated patch release process and enabled merged results pipelines for CNG: gitlab-org/charts/gitlab#4008 (comment 1588553608). Now that we have this, we can enable the early merge feature.

Author Check-list

  • [-] Has documentation been updated?
Edited by Steve Abrams

Merge request reports