fix: Adds details on checking CNG builds
What does this MR do and why?
- Also fix a documentation link
- The CNG builds only notify Distribution when they fail, and they also take awhile to start building.
- Adding this as a dedicated step ensures that we catch failures earlier in the process as sometimes they are pretty harmful
- Adds ability to run the security rake task in dry-run mode
Example!
Click Me to view!
First steps
-
Set the Due date on this issue with the planned Security publish date -
Start the security_release_prepare:start
job in the security release pipeline: foo-
Ensure the security_release:prepare
stage completes before continuing to the next section.
-
-
Modify the dates below to accurately reflect the plan of action. For example, if the planned due date is 28th, update the section titled "One day before due date" to "On 27th (One day before due date)".
Two days before due date
-
Check if the security release tracking issue contains any linked issues for projects under GitLab managed versioning that are not automatically processed (cng-ee, gitaly, gitlab-pages). -
If there are any linked issues, follow the release manager instructions and adjust this issue to include any additional steps needed. -
If a Gitaly security fix is included in the upcoming security release, follow the How to deal with Gitaly security fixes guide.
-
-
Before running the default merge chatops command, disable the security-target issue processor
pipeline schedule to ensure no other issues are linked to the security release tracking issue and no linked issues are inadvertently unlinked after this point. -
Check the issues linked to the security release tracking issue. If there are any that DO NOT have the security-target label applied, check to make sure they are expected to be included, otherwise unlink them and point the assignees to the correct process. -
Merge the merge requests targeting default branches # In Slack /chatops run release merge --security --default-branch
-
Verify that the table of issues in the security release tracking issue has been updated showing the default MRs have been merged or set to Merge When Pipeline Succeeds (MWPS/auto-merge).
One day before the due date
If this date is on a weekend, do this work on the next working day.
-
Start the security_release_release_preparation:start
job of the security release pipeline: foo -
Check that all MRs merged into the default branch have been deployed to production: # In Slack: /chatops run auto_deploy security_status
NOTE: This only checks
gitlab-org/security/gitlab
. If other projects have security MRs you should verify those manually. -
Make sure to execute the post-deploy migration pipeline to ensure that all post-deploy migrations have been executed: /chatops run post_deploy_migrations execute
-
Merge backports and any other merge request pending: # In Slack: /chatops run release merge --security
-
Ensure all Merge Requets associated with Implementation Issues with label reduced backports
are merged -
If any merge requests could not be merged, investigate what needs to be done to resolve the issues. Do not proceed unless it has been determined safe to do so. -
Ensure tests are green in CE and green in EE # In Slack: /chatops run release status --security
-
If all the security issues have been deployed to production, consider tagging.
On the Due Date
Packaging
-
Ensure tests are green in CE and green in EE # In Slack: /chatops run release status --security
For the next task: Waiting between pipelines is necessary as they may otherwise fail to concurrently push changes to the same project/branch.
-
Tag the 16.9.2 security release, and wait for the pipeline to finish: /chatops run release tag --security 16.9.2
-
Tag the 16.8.4 security release, and wait for the pipeline to finish: /chatops run release tag --security 16.8.4
-
Tag the 16.7.7 security release, and wait for the pipeline to finish: /chatops run release tag --security 16.7.7
-
Check that EE and CE packages are built. Please note the completion of the RAT-Tag
job on theslow_jobs
stage is not required for the next steps.- 16.9.2: EE packages and CE packages
- 16.8.4: EE packages and CE packages
- 16.7.7: EE packages and CE packages
-
Check that the CNG Images are built. Do not play any manual jobs. - 16.9.2: CNG builds
- 16.8.4: CNG builds
- 16.7.7: CNG builds
Deploy
-
Verify that release.gitlab.net is running the latest patch version - Check in Slack
#announcements
channel - Go to https://release.gitlab.net/help
- Check in Slack
Release
Consider communicating with the AppSec counterpart before publishing to sync on the time of releasing the blog post. Emails to the security mailing list are normally handled as a follow up task and should not delay release tasks
-
Publish 16.9.2 via ChatOps: /chatops run publish --security 16.9.2
-
Publish 16.8.4 via ChatOps: /chatops run publish --security 16.8.4
-
Publish 16.7.7 via ChatOps: /chatops run publish --security 16.7.7
-
Verify with AppSec release managers if the blog post is ready to be published. Do not proceed until AppSec has given green light -
Start the security_release_publish:start
stage of the security release pipeline: foo -
Verify that the check-packages
job completes:-
EE check-packages
on 16.9.2+ee.0 -
CE check-packages
on 16.9.2+ce.0 -
EE check-packages
on 16.8.4+ee.0 -
CE check-packages
on 16.8.4+ce.0 -
EE check-packages
on 16.7.7+ee.0 -
CE check-packages
on 16.7.7+ce.0
-
-
Create the versions: -
Create 16.9.2
version on version.gitlab.com. Be sure to mark it as a security release. From theSecurity Release
dropdown chooseNon Critical
. After it is created, theVulnerability Type
column should indicateNo
for the new version. -
Create 16.8.4
version on version.gitlab.com. Be sure to mark it as a security release. From theSecurity Release
dropdown chooseNon Critical
. After it is created, theVulnerability Type
column should indicateNo
for the new version. -
Create 16.7.7
version on version.gitlab.com. Be sure to mark it as a security release. From theSecurity Release
dropdown chooseNon Critical
. After it is created, theVulnerability Type
column should indicateNo
for the new version.
-
Final steps
-
Start the security_release_finalize:start
job in the security release pipeline: foo -
Sync the GitLab default branch by using the merge-train project: -
Disable the gitlab-org/gitlab@master -> gitlab-org/security/gitlab@master
pipeline schedule on the merge-train. -
Trigger the gitlab-org/security/gitlab@master -> gitlab-org/gitlab@master
pipeline schedule on the merge-train and wait until it finishes. This pipeline will attempt to sync the GitLab default branch. -
If the sync fails, repeat the above step.
-
-
If after 5 times the sync by the merge train continues to fail, use the previous strategy to sync the GitLab project: -
Disable the merge_train_to_canonical
feature flag on ops. -
Enable the gitlab-org/gitlab@master -> gitlab-org/security/gitlab@master
pipeline schedule on the merge-train. -
Execute the sync_remotes
task on Slack:/chatops run release sync_remotes --security
. In this case, if the sync fails, a merge request will be created and release manager intervention will be required.
-
-
Verify all remotes are synced: # In Slack /chatops run mirror status
If conflicts are found, manual intervention will be needed to sync the repositories.
Addresses: gitlab-com/gl-infra/delivery#20036
Author Check-list
-
Has documentation been updated?