Skip to content

Refactor CheckPackagesVerifier class

Dat Tang requested to merge dattang/refactor-check-package-service into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Content

  • Refactor CheckPackagesVerifier class

In order to use the same logic to check check-packages-availability and check-packages-functionality at two stages of the release pipelines (both monthly and patch), the CheckPackagesVerifier class is refactored:

  • Create a base class BaseCheckPackagesService
  • Use a new method bridge_job_name to require the inherited classes to define the trigger job name.
  • Rename CheckPackagesVerifier to CheckPackagesAvailabilityService to match the naming convention of classes in the services directory. Same naming convention is applied to CheckPackagesFunctionalityService and BaseCheckPackagesService.
  • Rename and add rspec files accordingly.

Ref: gitlab-com/gl-infra/delivery#20290 (closed)

Edited by Dat Tang

Merge request reports